Skip to content
This repository has been archived by the owner on Feb 25, 2025. It is now read-only.

Fetch upstream 17/09/24 #772

Closed
wants to merge 2,610 commits into from
Closed

Fetch upstream 17/09/24 #772

wants to merge 2,610 commits into from

Conversation

ghostwriternr
Copy link
Contributor

No description provided.

sandy081 and others added 30 commits September 11, 2024 14:53
* #223942 Block extension installation when signature verification fails

* fix tests
Swaps end for flex-end in browser/hover.css

Fixes justify-content value set in microsoft/vscode#210472 .

This resolves an autoprefixer warning while bundling with monaco-editor.

``` txt
autoprefixer: end value has mixed support, consider using flex-end instead
```

Co-authored-by: Aiday Marlen Kyzy <[email protected]>
Part of #221145
Not changing quick chat or inline chat, to start. Will also move chat attachments into this space, and possibly split the attachment/other buttons out of the execute toolbar
…273)

A remote extension can depend on built in descriptive extension that runs locally
* Collapse unchanged lines in input/metadata editors of NB Diff view

* Add support for Notebook Metadata Content Provider

* revert

* Fixes
* Workaround MSAL behavior

The main change this makes is around what scopes are being requested.

Due to an MSAL or Identity issue, if you request a resource like `FOO/user_impersonation` and then `email`... the 2nd call does not use Graph and instead uses FOO and FOO may not have an `email` scope available. To work around this, if we detect that all scopes being requested are [OIDC scopes](https://learn.microsoft.com/en-us/entra/identity-platform/scopes-oidc#openid-connect-scopes) then we tack on `User.Read` to make sure that what gets returned is in fact from Graph. This prevents an infinite loop that was happening before. MSAL/Identity should fix this behavior, but this works for now.

Additionally, MSAL does already tack on OIDC scopes to all requests so I removed the logic that adds those.

Couple small things:
* Make sure MSAL logs get logged (trace)
* Use a Sequencer to make sure acquireToken calls are done sequentially just in case.

* more comment
Tyriar and others added 22 commits September 17, 2024 06:38
Implement rectangle renderer and gpu rulers view part
Track buffer dirty changes and only upload dirty ranges
Expand object collection buffer when capacity hit
* update variable view for visible notebook editors

* update view title for REPL
Revert "Abstract find controller (#228812)"

This reverts commit 5dc2ffa.
* update decorations, support deleteRight, bugfixing, control saveParticipants

* wording tweaks
@ghostwriternr ghostwriternr self-assigned this Sep 18, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.